Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proposed pypy versions to matrix #225

Merged
merged 12 commits into from
Mar 10, 2020

Conversation

msarahan
Copy link
Member

@msarahan msarahan commented May 6, 2019

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@scopatz
Copy link
Member

scopatz commented May 7, 2019

LGTM

@isuruf
Copy link
Member

isuruf commented May 7, 2019

How does this work? Are there conda packages named python with version pypy.2.7.7.1?

Should this be done using a migrator instead of enabling this for all feedstocks at once?

@ocefpaf
Copy link
Member

ocefpaf commented May 7, 2019

Should this be done using a migrator instead of enabling this for all feedstocks at once?

I believe that the next step, before we merge this one, is a migrator. However, I think that the plan is to try 1-3 feedstocks first with this PR.

I'll be sprinting on ESIP stuff today but I'll try to give this a go.

@mattip
Copy link
Contributor

mattip commented May 13, 2019

@ocefpaf is there something I can do to "try 1-3 feedstocks first with this PR"?

@ocefpaf
Copy link
Member

ocefpaf commented May 16, 2019

@ocefpaf is there something I can do to "try 1-3 feedstocks first with this PR"?

@mattip you can try to install conda-smithy from this PR and re-render a feedstock. There are probably more details we need to solve though. I'll try to tackle this over the weekend. (I'm still trying to catch up with my e-mails after PyCon 😩)

@@ -543,6 +543,9 @@ python:
- 2.7
- 3.6
- 3.7
# pypy only supports win32 so far
- pypy.3.6.7.1 # [unix or win32]
- pypy.2.7.7.1 # [unix or win32]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have win32 builds?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyPy has only win32, no win64 at this time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point was I don't think we have ci setup to do win32 builds.

@CJ-Wright
Copy link
Member

CJ-Wright commented Oct 7, 2019

@msarahan do you mind if I write the cfep9 version of this?

Edit: actually what does the migration strategy look like for this? Do we rebuild everything python?

@isuruf isuruf requested a review from a team as a code owner February 3, 2020 15:58
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@CJ-Wright
Copy link
Member

How difficult of a rebuild do we expect this to be? (how often will we have to retool the recipes?) I wonder if we should try to roll out more automerge things before we set this off. (not that automerge should stop this, but it would make the maintainers' burden lower)

@isuruf
Copy link
Member

isuruf commented Mar 9, 2020

@conda-forge/core, do we start building everything or just a few packages first and then decide later?

@jakirkham
Copy link
Member

+1 for starting with a subset. It's unclear how much of the stack is needed yet. Besides we can always change our minds if it goes well.

@beckermr
Copy link
Member

We don’t have scoped migrations here yet so if we want a subset we’ll need to make a pr on the bot.

@isuruf
Copy link
Member

isuruf commented Mar 10, 2020

@beckermr, can we start slow then? 1 PR per hour with packages with more children more priority?

@jakirkham
Copy link
Member

How did this get solved for aarch64 and ppc64le?

@isuruf
Copy link
Member

isuruf commented Mar 10, 2020

What do you mean?

@beckermr
Copy link
Member

@jakirkham The arm and ppce migrations have a special migrator outside of the CFEP-9 migrations.

@beckermr
Copy link
Member

@isuruf We'll need to turn down the PRs here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/auto_tick.py#L501

@jakirkham See the special migrator here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/arch.py#L18

We had opened an issue to generalize the aarch/ppce migrator to handle "frontier" migrations. That issue is here: regro/cf-scripts#782

We had pypy in mind when discussing, but this issue has not been addressed yet.

@jakirkham
Copy link
Member

Thanks for the context! I like the term frontier migrator 😄

Sounds like Isuru's solution is easiest.

@beckermr
Copy link
Member

I think a better way to do this going forward is to support migrator options directly in the CFEP-9 YAML. We can allow people to set the number of PRs per hour, packages to ignore, a good list of feedstocks, etc.

@jakirkham
Copy link
Member

Yeah that seems sensible to me.

IDK if you are around @CJ-Wright. If so, any thoughts on this idea?

@beckermr
Copy link
Member

We apparently already support things like this which shows you how much I have to learn about the migrations code. ;p

@isuruf
Copy link
Member

isuruf commented Mar 10, 2020

This is blocked by conda-forge/conda-forge-ci-setup-feedstock#70

@ocefpaf
Copy link
Member

ocefpaf commented Mar 10, 2020

Looks like we are finally ready for this. Thanks @msarahan for the PR and the initial work, @mattip for the guidance and patience, and @isuruf for identifying and fixing all the issues that paved the way to merge this!

@ocefpaf ocefpaf merged commit 3935d62 into conda-forge:master Mar 10, 2020
@mattip
Copy link
Contributor

mattip commented Mar 10, 2020

Is there something to document both from the perspective of a recipe writer and from the perspective of an end user? It would be nice to make this option discoverable

@beckermr
Copy link
Member

Yes we should document in the main CF docs.

@isuruf
Copy link
Member

isuruf commented Mar 10, 2020

See https://conda-forge.org/docs/maintainer/knowledge_base.html#pypy-builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants