-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add proposed pypy versions to matrix #225
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
LGTM |
How does this work? Are there conda packages named Should this be done using a migrator instead of enabling this for all feedstocks at once? |
I believe that the next step, before we merge this one, is a migrator. However, I think that the plan is to try 1-3 feedstocks first with this PR. I'll be sprinting on ESIP stuff today but I'll try to give this a go. |
@ocefpaf is there something I can do to "try 1-3 feedstocks first with this PR"? |
@mattip you can try to install conda-smithy from this PR and re-render a feedstock. There are probably more details we need to solve though. I'll try to tackle this over the weekend. (I'm still trying to catch up with my e-mails after PyCon 😩) |
recipe/conda_build_config.yaml
Outdated
@@ -543,6 +543,9 @@ python: | |||
- 2.7 | |||
- 3.6 | |||
- 3.7 | |||
# pypy only supports win32 so far | |||
- pypy.3.6.7.1 # [unix or win32] | |||
- pypy.2.7.7.1 # [unix or win32] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have win32 builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyPy has only win32, no win64 at this time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point was I don't think we have ci setup to do win32 builds.
@msarahan do you mind if I write the cfep9 version of this? Edit: actually what does the migration strategy look like for this? Do we rebuild everything python? |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
…eedstock into add_python_impl_matrix
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
How difficult of a rebuild do we expect this to be? (how often will we have to retool the recipes?) I wonder if we should try to roll out more automerge things before we set this off. (not that automerge should stop this, but it would make the maintainers' burden lower) |
…rge-pinning-feedstock into add_python_impl_matrix
…eedstock into add_python_impl_matrix
@conda-forge/core, do we start building everything or just a few packages first and then decide later? |
+1 for starting with a subset. It's unclear how much of the stack is needed yet. Besides we can always change our minds if it goes well. |
We don’t have scoped migrations here yet so if we want a subset we’ll need to make a pr on the bot. |
@beckermr, can we start slow then? 1 PR per hour with packages with more children more priority? |
How did this get solved for |
What do you mean? |
@jakirkham The arm and ppce migrations have a special migrator outside of the CFEP-9 migrations. |
@isuruf We'll need to turn down the PRs here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/auto_tick.py#L501 @jakirkham See the special migrator here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/arch.py#L18 We had opened an issue to generalize the aarch/ppce migrator to handle "frontier" migrations. That issue is here: regro/cf-scripts#782 We had pypy in mind when discussing, but this issue has not been addressed yet. |
Thanks for the context! I like the term frontier migrator 😄 Sounds like Isuru's solution is easiest. |
I think a better way to do this going forward is to support migrator options directly in the CFEP-9 YAML. We can allow people to set the number of PRs per hour, packages to ignore, a good list of feedstocks, etc. |
Yeah that seems sensible to me. IDK if you are around @CJ-Wright. If so, any thoughts on this idea? |
We apparently already support things like this which shows you how much I have to learn about the migrations code. ;p |
This is blocked by conda-forge/conda-forge-ci-setup-feedstock#70 |
Is there something to document both from the perspective of a recipe writer and from the perspective of an end user? It would be nice to make this option discoverable |
Yes we should document in the main CF docs. |
ping @ocefpaf @mattip